Hi Dermot, did you have quick look at final webrevs? I saw you had some comments earlier. Is it ok to include you as one of reviewers?
Thanks, Petr Petr Sumbera wrote: > While working as sponsor for Expect integration I did following changes > against original webrev (see bellow): > > * prototype_com > - added back inclusion of "depend" file > - removed directory usr/lib/expect5.43 (not in proto area, not used) > - changed group name for usr/share from "bin" to "sys" > - for usr/lib/libexpect5.43.so set mask to 555 (was 444) > > * depend > - created, contains dependency on SUNWTcl and SUNWTk > > * install-sfw > - libexpect5.43.so is installed as executalbe (_install E, mask 555) > > Any comments? > > Thanks, > > Petr > > S h i v wrote: >> This is a review request as per Petr's suggestion for making expect >> available in SFW. >> >> http://opensource.shivakumar.info/webrevs/expect_webrev_modified >> >> If one had had a look at the previous B77 based changes that were >> published, the delta compared to that are as below >> <copy_from_below_mail> >> - changed some headers/copyright so there are the newest one we use >> - added correct ident strings >> - added to package copyright preamble we are made to use (as far as I know) >> - removed "depend" from protoype_com (i didn't see anywhere depend >> file. is it ok?) >> </copy_from_below_mail> >> >> regards >> Shiv > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
