Yes, you can include me as a code reviewer.
A few final comments:
- usr/src/pkgdefs/SUNWexpect/prototype_com
Some lines aren't sorted alphabetically, which I know
the SFWNV team like done, eg:
63 f none usr/demo/expect/tknewsbiff 555 root bin
64 f none usr/demo/expect/tkpasswd 555 root bin
65 f none usr/demo/expect/timed-read 555 root bin
66 f none usr/demo/expect/timed-run 555 root bin
- usr/src/pkgdefs/SUNWexpect/pkginfo.tmpl
are you sure it's OK to put the community pkg's version
here like this: SUNW_PRODVERS="RELEASE/5.43"?
every other pkg seems to use this value:
SUNW_PRODVERS="RELEASE/VERSION" here, which gets
translated to SUNW_PRODVERS=5.11/SunOS Development
I'd prefer to see the community's version in () in the
description, eg:
DESC="expect - Programmed dialogue with other interactive \
programs (5.43)"
- I don't see any usr/src/pkgdefs/SUNWexpect/depend file.
I would have expected a "DATAFILES= depend" line in the
Makefile or a custom depend file? In fact, it looks like
expect depends on SUNWTcl and SUNWTk at least?
Dermot
