Dermot McCluskey wrote: > A few final comments: > - usr/src/pkgdefs/SUNWexpect/prototype_com > Some lines aren't sorted alphabetically, which I know > the SFWNV team like done, eg: > 63 f none usr/demo/expect/tknewsbiff 555 root bin > 64 f none usr/demo/expect/tkpasswd 555 root bin > 65 f none usr/demo/expect/timed-read 555 root bin > 66 f none usr/demo/expect/timed-run 555 root bin
Fixed. See changes bellow. > - usr/src/pkgdefs/SUNWexpect/pkginfo.tmpl > are you sure it's OK to put the community pkg's version > here like this: SUNW_PRODVERS="RELEASE/5.43"? > every other pkg seems to use this value: > SUNW_PRODVERS="RELEASE/VERSION" here, which gets > translated to SUNW_PRODVERS=5.11/SunOS Development > I'd prefer to see the community's version in () in the > description, eg: > DESC="expect - Programmed dialogue with other interactive \ > programs (5.43)" I think there were more problems. So I took version from recently integrated VIM and reused it. Again see bellow: > - I don't see any usr/src/pkgdefs/SUNWexpect/depend file. > I would have expected a "DATAFILES= depend" line in the > Makefile or a custom depend file? In fact, it looks like > expect depends on SUNWTcl and SUNWTk at least? This was already fixed before. I haven't regenerated webrevs since they are on Shiv's server (and the changes were quite small). Please see them listed in email you were replying to. Thanks, Petr --- - Thu Dec 6 05:56:41 2007 +++ usr/src/pkgdefs/SUNWexpect/prototype_com Thu Dec 6 05:56:27 2007 @@ -61,10 +61,10 @@ f none usr/demo/expect/passmass 555 root bin f none usr/demo/expect/rftp 555 root bin f none usr/demo/expect/rlogin-cwd 555 root bin -f none usr/demo/expect/tknewsbiff 555 root bin -f none usr/demo/expect/tkpasswd 555 root bin f none usr/demo/expect/timed-read 555 root bin f none usr/demo/expect/timed-run 555 root bin +f none usr/demo/expect/tknewsbiff 555 root bin +f none usr/demo/expect/tkpasswd 555 root bin f none usr/demo/expect/unbuffer 555 root bin f none usr/demo/expect/weather 555 root bin f none usr/demo/expect/xkibitz 555 root bin @@ -86,8 +86,8 @@ d none usr/include 755 root bin f none usr/include/expect.h 444 root bin -f none usr/include/expect_tcl.h 444 root bin f none usr/include/expect_comm.h 444 root bin +f none usr/include/expect_tcl.h 444 root bin f none usr/include/tcldbg.h 444 root bin d none usr/lib 755 root bin @@ -99,8 +99,8 @@ d none usr/share 755 root sys d none usr/share/man 755 root bin d none usr/share/man/man1 755 root bin -f none usr/share/man/man1/expectk.1 444 root bin f none usr/share/man/man1/expect.1 444 root bin +f none usr/share/man/man1/expectk.1 444 root bin d none usr/share/man/man3 755 root bin f none usr/share/man/man3/libexpect.3 444 root bin --- bash-3.2$ cat usr/src/pkgdefs/SUNWexpect/pkginfo.tmpl # # # CDDL HEADER START # # The contents of this file are subject to the terms of the # Common Development and Distribution License (the "License"). # You may not use this file except in compliance with the License. # # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE # or http://www.opensolaris.org/os/licensing. # See the License for the specific language governing permissions # and limitations under the License. # # When distributing Covered Code, include this CDDL HEADER in each # file and include the License file at usr/src/OPENSOLARIS.LICENSE. # If applicable, add the following below this CDDL HEADER, with the # fields enclosed by brackets "[]" replaced with your own identifying # information: Portions Copyright [yyyy] [name of copyright owner] # # CDDL HEADER END # # Copyright 2007 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # #ident "@(#)pkginfo.tmpl 1.1 07/12/06 SMI" # # # This required package information file describes characteristics of the # package, such as package abbreviation, full package name, package version, # and package architecture. # PKG="SUNWexpect" NAME="expect - Programmed dialogue with other interactive programs" ARCH="ISA" VERSION="SFWVERS,REV=0.0.0" SUNW_PRODNAME="SunOS" SUNW_PRODVERS="RELEASE/VERSION" SUNW_PKGTYPE="usr" MAXINST="1000" CATEGORY="system" DESC="expect - Programmed dialogue with other interactive programs" VENDOR="Sun Microsystems, Inc." HOTLINE="Please contact your local service provider" EMAIL="" CLASSES="none" BASEDIR=/ SUNW_PKGVERS="1.0" SUNW_PKG_ALLZONES="false" SUNW_PKG_HOLLOW="false" SUNW_PKG_THISZONE="false" #VSTOCK="<reserved by Release Engineering for package part #>" #ISTATES="<developer defined>" #RSTATES='<developer defined>' #ULIMIT="<developer defined>" #ORDER="<developer defined>" #PSTAMP="<developer defined>" #INTONLY="<developer defined>"
