Bobbie, See comments below ...
Paul Bobbie wrote: > > I am working on porting the logilab-astng python libraries. These > libraries are used by pylint (python lint). If I could get some > review and feeback, I'd appreciate it. > > http://cr.opensolaris.org/~blong/logilab-astng/ === Start of comments === 1. usr/src/Targetdirs & usr/src/lib/Makefile & usr/src/pkgdefs/Makefile What is the stuff that webrev shows as deleted ? Does it need resyncing with the gate. 2. usr/src/lib/logilab-astng/METADATA The SRC: link didn't work when I tried it, please check: the following works though .. "http://ftp.logilab.org/pub/astng/logilab-astng-0.19.0.tar.gz"; The URL: link could be (I think) ... "http://www.logilab.org/project/logilab-astng"; 3. usr/src/lib/logilab-astng/Makefile.sfw Delete line ... 36 $(VER)/build/proto: and make that rules contents those of the 'all:' rule. Line 37, change 'python' to '$(PYTHON)'. Add 'env - ' in front of all the 'python' invocations. Lines ... 43 (cd $(VER); $(PYTHON) setup.py install --root=$(LOCALPROTO)) 44 (cd $(VER)/$(LOCALPROTO)/usr/lib/python2.4/site-packages; \ 45 cp -R * $(REALPROTO)) why not install it directly into the ws proto area? Then use 'protofix' to correct the file permissions. In rule ... 9 $(VER)/setup.py do you need to 'touch' the 'setup.py' file after extracting the tarball After line 27 (VER=) add ... TARBALL=$(VER).tar.gz then replace '$(VER).tar.gz' with '$(TARBALL) throughout. Line ... 29 REALPROTO=$(ROOT)/usr/lib/python2.4/vendor-packages a number of integrations are now using '/usr/lib/python2.4' so you might want to define it in Makefile.master and use that, for example something like ... In Makefile.master define PYTHONLIB=/usr/lib/python2.4 in Makefile.sfw change line above to .. REALPROTO=$(ROOT)/$(PYTHONLIB)/vendor-packages 4. usr/src/lib/logilab-astng/sunman-stability Is this used, if not delete it 5. usr/src/pkgdefs/SUNWlogilab-astng/prototype_com Remove the write permission bits from the files installed into /usr. And in Makefile.sfw use 'protofix' to correct them in the proto area (see item (3)). === End of comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
