Bobbie, This mainly looks okay to me, just one more comment, see below ..
Paul Bobbie wrote: > Ok, I think I've gotten everything, Please see the webrev at: > http://cr.opensolaris.org/~blong/logilab-astng.incr/ > > thanks for your help. >>>> Bobbie wrote: >>>>> >>>>> I am working on porting the logilab-astng python libraries. These >>>>> libraries are used by pylint (python lint). If I could get some >>>>> review and feeback, I'd appreciate it. >>>>> >>>>> http://cr.opensolaris.org/~blong/logilab-astng/ 1. usr/src/lib/logilab-astng/logilab-astng.3.sunman Should this have the CDDL and Copyright stuff added? as in ... "http://cr.opensolaris.org/~drewfish/logilab-common-3/usr/src/lib/logilab-common/logilab-common.3.sunman.html"; -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
