Vector - I am happy with your changes. No more issues from me on this.
Steve C. Vector Li wrote: > Hi Steve, > Thanks much for your comments. > > Steven M. Christensen wrote: >> Vector - >> >> A few comments. >> >> A typical bvi 1.3.2 install also has the bvedit link to bvi - like bmore. >> > Yes, bvedit/bview are just links to bvi. > Link for bvedit/bview in bvi-1.3.2/Makefile is hard link, > $ cat -n bvi-1.3.2/Makefile > ... ... > 72 @ln $(bindir)/bvi $(bindir)/bview > 73 @ln $(bindir)/bvi $(bindir)/bvedit > ... ... > and I think soft link is better. > Added bvedit/bview soft link now. > > BTW, bmore and bvi are different binary files. >> There is a file called bmore.help that usually gets installed which >> you do not have. It may not be that important, but you might want to >> check. >> > As for bmore.help, which is a text file used by binary file bmore. > >> In my build, I get a dependency on ncurses which you may or may not >> get. If you do, then you might need a depend file. If not, you won't. > ncurses is optional, to run ./configure by default, we will get (from > config.log): > 375 ac_cv_header_ncurses_h='no' > 376 ac_cv_header_ncurses_term_h='no' > So I don't think we have to add a dependency on ncurses. > >> >> Steve C. >> >> Vector Li wrote: >>> Hi, >>> I am porting bvi, a visual editor for binary files. >>> >>> Would you please help me to review the changes? >>> webrev at: >>> http://cr.opensolaris.org/~vector/bvi/ >>> >>> Thanks a lot! >>> > The webrev is updated, I just updated these two files: > - usr/src/cmd/bvi/install-sfw > - usr/src/pkgdefs/SUNWbvi/prototype_com > Please take a look again, thx! >
