Vector, This mainly looks good to me, but see comments below ...
Paul Vector Li wrote: > > I am porting bvi, a visual editor for binary files. > > Would you please help me to review the changes? > webrev at: > http://cr.opensolaris.org/~vector/bvi/ 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile These need resyncing with the gate/clone so it doesn't look as though you are changing other stuff. 2. usr/src/cmd/bvi/Makefile.sfw Line ... 50 /usr/bin/gzip -dc $(TARBALL) | /usr/bin/tar xpf - - change '/usr/bin/tar' to $(TAR) - you might want to add the 'o' option to tar 3. depend You are using the default 'depend', have you checked there are no other dependencies with the dependency-checker script? 4. usr/src/pkgdefs/SUNWbvi/copyright Are there any 'source-owner' copyright statements that can be extracted for the unpacked tarball and added here after the Sun disclaimer, eg. as in ... "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 5. usr/src/pkgdefs/SUNWbvi/pkginfo.tmpl Cosmetic: on the DESC= line add a space before '(1.3.2)', eg. ".... Editor (1.3.2)" 6. usr/src/pkgdefs/SUNWbvi/prototype_com Don't install stuff into /usr with the write permission bit set (the permissions are okay in install-sfw). END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
