Hi Paul, Thanks for your comments! Paul Cunningham wrote: > Vector, > > This mainly looks good to me, but see comments below ... > > Paul > > Vector Li wrote: >> >> I am porting bvi, a visual editor for binary files. >> >> Would you please help me to review the changes? >> webrev at: >> http://cr.opensolaris.org/~vector/bvi/ > > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > These need resyncing with the gate/clone so it doesn't > look as though you are changing other stuff. > Well, done. > 2. usr/src/cmd/bvi/Makefile.sfw > Line ... > 50 /usr/bin/gzip -dc $(TARBALL) | /usr/bin/tar xpf - > - change '/usr/bin/tar' to $(TAR) > - you might want to add the 'o' option to tar > Done. > 3. depend > You are using the default 'depend', have you checked there > are no other dependencies with the dependency-checker script? > Done. > 4. usr/src/pkgdefs/SUNWbvi/copyright > Are there any 'source-owner' copyright statements that can be > extracted for the unpacked tarball and added here after the > Sun disclaimer, eg. as in ... > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; > > > I have taken a look at the source codes and got such "Copyright", bvi-1.3.2$ find . -name "*.*" | xargs grep -i copyright ./bm_dos.c: * Copyright 1996-2003 by Gerhard Buergmann ./bmore.c: * Copyright 1990-2004 by Gerhard Buergmann ./bmore.c:char *copyright = "Copyright (C) 1990-2004 by Gerhard Buergmann"; ./bmore.c.old: * Copyright 1990-2003 by Gerhard Buergmann ./bmore.c.old:char *copyright = "Copyright (C) 1990-2003 by Gerhard Buergmann"; ./bmore.h: * Copyright 1996-2003 by Gerhard Buergmann ./bm_unix.c: * Copyright 1996-2003 by Gerhard Buergmann ./bvi.c: * Copyright 1996-2004 by Gerhard Buergmann ./bvi.c:char *copyright = "Copyright (C) 1996-2004 by Gerhard Buergmann"; ./bvi.h: * Copyright 1996-2003 by Gerhard Buergmann ./bvi.h:extern char *copyright, *notfound; ./comm.c: * Copyright 1996-2003 by Gerhard Buergmann ./comm.c: sprintf(string, "bvi version %s %s", VERSION, copyright); ./config.guess:# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, ./config.guess:Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001 ./config.sub:# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, ./config.sub:Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001 ./dosconf.h: * Copyright 1996-2002 by Gerhard Buergmann ./doscur.h: * Copyright 1996-2002 by Gerhard Buergmann ./dosio.c: * Copyright 1996-2002 by Gerhard Buergmann ./edit.c: * Copyright 1996-2003 by Gerhard Buergmann ./edit.c: printf("\nbvi version %s %s\n", VERSION, copyright); ./io.c: * Copyright 1996-2004 by Gerhard Buergmann ./Makefile.in:# Copyright (c) 1996-2003 by Gerhard Buergmann ./re.c: * Copyright 1996-2003 by Gerhard Buergmann ./recomp.c: * Copyright 1996-2002 by Gerhard Buergmann ./set.c: * Copyright 1996-2003 by Gerhard Buergmann ./set.h: * Copyright 1996-2002 by Gerhard Buergmann
So I append two items to usr/src/pkgdefs/SUNWbvi/copyright, Copyright (C) 1990-2004 Gerhard Buergmann <gerhard at puon.at> Copyright (C) 1992-2001 Free Software Foundation, Inc. > 5. usr/src/pkgdefs/SUNWbvi/pkginfo.tmpl > Cosmetic: on the DESC= line add a space before '(1.3.2)', eg. > ".... Editor (1.3.2)" > Updated. > 6. usr/src/pkgdefs/SUNWbvi/prototype_com > Don't install stuff into /usr with the write permission bit set > (the permissions are okay in install-sfw). Changed. > > END Webrev at: http://cr.opensolaris.org/~vector/bvi/ Please take a look again, thanks! -- Regards, Vector Tel: +86-10-6267-3534 | SWAN: x80534
