This mainly looks okay to me, see below for a comments ... Paul
Vivek Titarmare wrote: > I have posted a webrev for package "slf4j" which I am porting to Nevada > and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835986-slf4j/ > 1. usr/src/lib/Makefile Why are there now two 'FRC:' rules ? 164 165 FRC: 166 ore 167 168 FRC: 2. usr/src/pkgdefs/Makefile Add the new entry alphabetically 3. usr/src/pkgdefs/SUNWslf4j/copyright & usr/src/lib/slf4j/METADATA Is the licence correct here ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
