Vivek,

Vivek Titarmare wrote:
> 
> The license page says about GPL, ASL and MIT License Should I mention all
> the 3 licenses?
> Should the copyright file mention only about the
> http://www.slf4j.org/license.html text? (Actually this text does not have
> contain specifically GPL, ASL and MIT license)
> 
> Pl. suggest.

Sorry I do not know, try asking Norm or Mike (CC'ed)

Paul

> 
> -----Original Message-----
> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] 

> 
> This looks okay except for below ....
> 

> 
> Vivek Titarmare wrote:
>> Yes, the url and the license are correct. I was able to open the url
> today.
>> Seems to be some issue yesterday on opening the url.
>>
>> Rest of the changes are done and webrev uploaded at
>> http://cr.opensolaris.org/~vivekrt/6835986-slf4j/ .
>>
>> Let me know if I am missing any.
> 
>> -----Original Message-----
>> From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] 
> 
>> Paul Cunningham wrote:
> 
>>> Vivek Titarmare wrote:
>>>> I have posted a webrev for package "slf4j" which I am porting to 
>>>> Nevada and would like to request a code review. Please see the link
> below
>>>> http://cr.opensolaris.org/~vivekrt/6835986-slf4j/
> 
>    .. cut ..
> 
>>> 3. usr/src/pkgdefs/SUNWslf4j/copyright
>>>     & usr/src/lib/slf4j/METADATA
>>>    Is the licence correct here ?
> 
> What I was trying to point out here was ...
> 
> in the METADATA file it says ...
>     4 LICENSE:          GPL
> but the pkg's website licence says different ...
>     http://www.slf4j.org/license.html
> so why are you referring to the GPL licence? Don't you just need what is 
> in http://www.slf4j.org/license.html in the 'SUNWslf4j/copyright' file 
> (plus any source-owner copyright lines).
> 
>    .. cut ..
> 

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to