Caijian, caijian guo - Sun Microsystems - Beijing China wrote: > > Thanks for your review. > I have fixed all the issues except using gcc. > Updated web review at: > http://cr.opensolaris.org/~caijian/bwm-ng/ > > About gcc or Sun cc issue, I did try to investigate . > Now I have successfully compile bwm-ng using sun cc, but I have to > remove the key work "inline" before some functions. > since bwm-ng is just a cmd package , not a library and gcc compiles it > well without modifying the source codes. > So, it is possible that I still use gcc ?
Personally I think as you can get it to build with the Sun Compiler you should use that (rather than gcc). And also pass the required patches back to the bwm-ng opensource community for inclusion in future releases (assuming they accept it). Paul > > Below are the issues I met when I used S12 cc : > > ./configure CC=/ws/onnv-tools/SUNWspro/SS12/bin/cc CFLAGS="-xO3 -m32 > -xchip=pentium -xspace -Xa -xildoff -xc99=all " > make > ... > /ws/onnv-tools/SUNWspro/SS12/bin/cc -xO3 -m32 -xchip=pentium -xspace -Xa > -xildoff -xc99=all -L. -o bwm-ng bwm-ng.o process.o output.o options.o > help.o curses_tools.o retrieve.o libkstat.o netstat.o -lcurses -lkstat > Undefined first referenced > symbol in file > get_iface_stats bwm-ng.o > print_help_line help.o > calc_new_values process.o > save_max process.o > save_avg_values process.o > ld: fatal: symbol referencing errors. No output written to bwm-ng > > then I removed the "inline" before those functions above. > then it worked well. > > > > ? 2009?03?02? 19:00, Srirama Sharma ??: >> Hi Caijian, >> >> Below are few comments: >> >> 1. In METADATA file, generally porting issues or any notes have to be >> specified in COMMENTS field. So you could change >> >> 12 COMMENTS: a live network and disk io bandwidth monitor. >> >> to >> 12 COMMENTS: >> >> >> >> 2. In Makefile.sfw, >> - As suggested by Paul, it is preferred to use Sun Studio 12 >> compilers. Most of the components use the same. >> >> - Do you really require below line ? If not please remove it. >> >> 54 .SUFFIXES: >> >> >> 3. In install-sfw, >> - Please add "#!/bin/ksh93" in the first line. >> >> 4. Make sure you resolve the conflicts in usr/src/pkgdefs/Makefile. If >> not you would be removing the changes done to sfw with recent >> integrations. >> >> Thanks, >> Srirama >> >> caijian guo - Sun Microsystems - Beijing China said the following on >> Tuesday 24 February 2009 05:44 PM: >>> Hi All, >>> >>> I am porting "bwm-ng". It is a live network and disk io throughput >>> monitor. >>> Obtains statistics data from "kstat"; Supports both ipv4 and v6; Works >>> well on both x86 and sparc. >>> >>> Webrev at: >>> >>> http://cr.opensolaris.org/~caijian/bwm-ng/ >>> -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
