Caijian, This mainly looks good to me, see below for a couple of comments ...
Paul caijian guo - Sun Microsystems - Beijing China wrote: > > I am porting "bwm-ng". It is a live network and disk io throughput monitor. > Obtains statistics data from "kstat"; Supports both ipv4 and v6; Works > well on both x86 and sparc. > > Webrev at: > http://cr.opensolaris.org/~caijian/bwm-ng/ === Start of Comments === 1. usr/src/cmd/bwm-ng/METADATA The SRC: line should probably be ... SRC: http://www.gropp.org/bwm-ng/bwm-ng-0.6.tar.gz 2. usr/src/cmd/bwm-ng/Makefile.sfw I see you are using gcc to build this: Will it build with the Sun compilers, if so can you use that instead (as preferred compiler)? === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
