Hi Paul,
Does it matter if I use gcc ?
Since it works well with gcc, so I think there is no need to change it
to sun cc. It that right ?
Caijian
? 2009?02?26? 16:24, Paul Cunningham ??:
>
>
> caijian guo - Sun Microsystems - Beijing China wrote:
>>
>> Thanks very much for your review
>> It works well when I use gcc, but it failed when I used sun compiler
>> below :
>
> sorry I can't help you with why it failed, you will have to look
> deeper. But it's normally quite easy to fix the compile errors with
> patches (which can then be passed back to the pkg's community), so you
> might want to see if they can be fixed easily.
>
> Paul
>
>>
>> bash-3.2# ./configure CC=/ws/onnv-tools/teamware/bin/cc
>> checking for a BSD-compatible install... /usr/bin/ginstall -c
>> checking whether build environment is sane... yes
>> checking for gawk... gawk
>> checking whether make sets $(MAKE)... yes
>> checking for style of include used by make... GNU
>> checking for gcc... /ws/onnv-tools/teamware/bin/cc
>> checking for C compiler default output file name...
>> configure: error: C compiler cannot create executables
>> See `config.log' for more details.
>> bash-3.2# cat config.log
>> ...
>> ...
>> configure:2372: checking for gcc
>> configure:2399: result: /ws/onnv-tools/teamware/bin/cc
>> configure:2637: checking for C compiler version
>> configure:2644: /ws/onnv-tools/teamware/bin/cc --version >&5
>> cc: Warning: option -- passed to ld
>> usage: cc [ options] files. Use 'cc -flags' for details
>> configure:2647: $? = 1
>> configure:2654: /ws/onnv-tools/teamware/bin/cc -v >&5
>> usage: cc [ options] files. Use 'cc -flags' for details
>> configure:2657: $? = 1
>> configure:2664: /ws/onnv-tools/teamware/bin/cc -V >&5
>> cc: Sun C 5.5 Patch 112761-06 2004/01/13
>> usage: cc [ options] files. Use 'cc -flags' for details
>> configure:2667: $? = 1
>> configure:2690: checking for C compiler default output file name
>> configure:2717: /ws/onnv-tools/teamware/bin/cc -O2 -Wall conftest.c >&5
>> cc: Warning: option -2 passed to ld
>> cc: illegal option -Wall
>> configure:2720: $? = 1
>> configure:2758: result:
>> configure: failed program was:
>> | /* confdefs.h. */
>> | #define PACKAGE_NAME "bwm-ng"
>> | #define PACKAGE_TARNAME "bwm-ng"
>> | #define PACKAGE_VERSION "0.6"
>> | #define PACKAGE_STRING "bwm-ng 0.6"
>> | #define PACKAGE_BUGREPORT "bwmng at gropp.org"
>> | #define PACKAGE "bwm-ng"
>> | #define VERSION "0.6"
>> | /* end confdefs.h. */
>> |
>> | int
>> | main ()
>> | {
>> |
>> | ;
>> | return 0;
>> | }
>> configure:2765: error: C compiler cannot create executables
>> See `config.log' for more details.
>>
>>
>>
>>
>> bash-3.2# ./configure CC=/ws/onnv-tools/SUNWspro/SS11/bin/cc
>> checking for a BSD-compatible install... /usr/bin/ginstall -c
>> checking whether build environment is sane... yes
>> checking for gawk... gawk
>> checking whether make sets $(MAKE)... yes
>> checking for style of include used by make... GNU
>> checking for gcc... /ws/onnv-tools/SUNWspro/SS11/bin/cc
>> checking for C compiler default output file name...
>> configure: error: C compiler cannot create executables
>> See `config.log' for more details.
>> bash-3.2#
>>
>>
>>
>>
>> Caijian
>>
>>
>>
>> ? 2009?02?25? 18:46, Paul Cunningham ??:
>>> Caijian,
>>>
>>> This mainly looks good to me, see below for a couple of comments ...
>>>
>>> Paul
>>>
>>> caijian guo - Sun Microsystems - Beijing China wrote:
>>>>
>>>> I am porting "bwm-ng". It is a live network and disk io throughput
>>>> monitor.
>>>> Obtains statistics data from "kstat"; Supports both ipv4 and v6; Works
>>>> well on both x86 and sparc.
>>>>
>>>> Webrev at:
>>>> http://cr.opensolaris.org/~caijian/bwm-ng/
>>>
>>> === Start of Comments ===
>>>
>>> 1. usr/src/cmd/bwm-ng/METADATA
>>> The SRC: line should probably be ...
>>> SRC: http://www.gropp.org/bwm-ng/bwm-ng-0.6.tar.gz
>>
>>
>> Accept
>>
>>
>>
>>>
>>> 2. usr/src/cmd/bwm-ng/Makefile.sfw
>>> I see you are using gcc to build this: Will it build with
>>> the Sun compilers, if so can you use that instead (as
>>> preferred compiler)?
>>>
>>> === End of Comments =====
>>
>
