Nicolas Williams wrote: > On Wed, Feb 25, 2009 at 02:51:53PM +0100, Petr Sumbera wrote: >> http://cr.opensolaris.org/~xsumbe00/6567201-wireshark/ > > - usr/src/cmd/wireshark/Patches/bug3161.patch > > Could this be a CPPFLAG passed in the ./configure command line?
Well I have tried and there are some other files which don't like it (they use u_char). Anyway I think via patch we can better monitor during upgrade whether this problem was in community solved. > - usr/src/pkgdefs/SUNWwireshark/copyright > > 15 Part I: Some remarks regarding the license given in > > Too terse for me :) > > How about: > > 15 Part I: Some remarks regarding the license given in part II. > > - usr/src/pkgdefs/SUNWwireshark/copyright > > Why is the remark about tools/pidl needed? Not that it causes harm. > Just curious. It all comes from wireshark-1.0.6/COPYING. But I think it's perfectly OK start with just PART 2. Updated. > - The copyright remarks seem to indicate that wireshark libraries can > be used by other apps. Are these libraries any flavor of Public > interfaces in OpenSolaris? If so, why are there no 64-bit versions? They are project private as defined in PSARC. Webrev updated. Petr
