Gordon Ross wrote: > usr/src/common/rbac/exec_attr > Should there be a postinstall script or something > to get these lines added during an upgrade?
As far as I know nothing more (beside rbac class action script) is needed. I'm following sfw examples SUNWpostgr-82-server-data-root and SUNWquaggar). No change here. > usr/src/pkgdefs/SUNWwireshark/depend > Why is bash in the dependencies? (just curious:) You are right. It was needed by idl2wrs.sh. But I decided to not ship it as it need some extra python modules to be installed. I removed this dependency. > usr/src/pkgdefs/SUNWwireshark/pkginfo.tmpl > I think "usr" type packages normally have: > SUNW_PKG_ALLZONES="true" > [note 1] I was told by more knowledgeable person in this area not to do that. Also all other packages in SFW (except SUNWipmi and SUNWipmir) have it as "false". No change here. > usr/src/pkgdefs/SUNWwiresharkr/copyright > There is nothing but Sun-owned content in this package, > so this should use the standard Sun copyright. > (just delete your copyright file in here) Done. > usr/src/pkgdefs/SUNWwiresharkr/pkginfo.tmpl > I think "root" packages normally have: > SUNW_PKG_ALLZONES="true" > It might also be appropriate to set: > SUNW_PKG_HOLLOW="true" > [note 1] I was told that SUNW_PKG_HOLLOW has meaning only when SUNW_PKG_ALLZONES is set. No change here. Webrev is updated. Petr > note 1: You should get advice from someone who knows > the package rules better than I do. Let me know if > you have trouble finding someone for that. > > Otherwise looks good to me. > > Thanks, > Gordon
