On Thu, Mar 12, 2009 at 05:35:36PM +0100, Marcel Telka wrote: > On Thu, Mar 12, 2009 at 11:10:06AM -0500, Norm Jacobs wrote: > > Marcel Telka wrote: > >> On Thu, Mar 12, 2009 at 03:02:00PM +0100, Petr Sumbera wrote: > >> > >>> Marcel Telka wrote: > >>> > >>>> On Wed, Feb 25, 2009 at 02:51:53PM +0100, Petr Sumbera wrote: > >>>> > >>>>> http://cr.opensolaris.org/~xsumbe00/6567201-wireshark/ > >>>>> > >>>> usr/src/cmd/wireshark/Makefile.sfw > >>>> ---------------------------------- > >>>> > >>>> Do you really need to pass whole TARGET_ENV to make commands? For > >>>> example (at > >>>> least) INSTALL shouldn't be required. > >>>> > >>> INSTALL makes Wireshark to use SFW special install script which is > >>> compatible with BSD one. This way for example installed man pages are > >>> processed by sunman-stability sed script (referred by MANSCRIPT). > >>> > >> > >> AFAIK, path to install binary is detected by the configure script and it is > >> stored in the build system in the generated Makefile. In this case the > >> value of > >> INSTALL is used, so the correct one is detected/used. Passing INSTALL > >> again to > >> make is noop because you just override the previously stored INSTALL (both > >> are > >> equal). > >> > >> > > INSTALL=$(INSTALL_PROTO) makes the build use ${SRC}/tools/install-proto > > instead of GNU/BSD/... install. As Petr mentioned, install-proto performs > > some additional processing. > > Sorry, I was probably not clear in my post. > > I am trying to say that: > > ./configure INSTALL=$(INSTALL_PROTO) > make > > is enough. > > This one: > > ./configure INSTALL=$(INSTALL_PROTO) > INSTALL=$(INSTALL_PROTO) make > > is not required. That's all.
Assuming `env -` is used properly (i.e. before the make line) so there is no stale INSTALL environment variable set. > > In both cases the right INSTALL_PROTO should be used (assuming there is no bug > in wireshark build system). This should be true for all autotools[*] > compatible > build systems. > > [*] based on autoconf/automake -- Marcel Telka Solaris RPE
