On Mon, 2009-06-01 at 09:00 +0100, Paul Cunningham wrote:
> Here are a few comments ....
> 
> Paul
> 
> Mark Phalan wrote:
> > 
> > On 29 May 2009, at 17:01, Mark Phalan wrote:
> > 
> >>
> >> I just updated the webrev for:
> >> 6759600 include perl bindings for openssl
> 
> > http://cr.opensolaris.org/~mbp/6759600-net_ssleay/
> 
> 1. usr/src/lib/perl_net_ssleay/Makefile.sfw
>     Change all 'env ' to 'env - '
> 
>     Lines ...
>       63                 -s Volatile $(MAN3DIR)/Net::SSLeay.3 \
>       64                 -s Volatile $(MAN3DIR)/Net::SSLeay::Handle.3; \
>     is "Volatile" the correct stability level

That's what was approved in the PSARC case (2009/189).

> 
>     Line ...
>       60         $(SRC)/tools/protofix --write --pkg $(PKG)
>     what is this line doing?

It's making the files in the proto area writable (if they exist). This
allows "make -f Makefile.sfw install" to be run multiple times without
error (incrementals).

> 
> 
> 2. usr/src/pkgdefs/Makefile
>     Add item alphabetically

Done.

Webrev has been updated.

Thanks,

-Mark


Reply via email to