George,

This looks okay to me, but you could do the following ...

Paul

George Vasick wrote:
> 
> I am looking for reviewers for the upgrade of automake to 1.10.2:
> 
> http://cr.opensolaris.org/~gvasick/automake/

1. usr/src/cmd/automake/automake-1.10/install-sfw

    Pass the VER= info in from the Makefile.sfw (so you
    don't have to keep changing it for every src pkg version
    update).

    Apply the following ...
    Roland Mainz wrote:
    > use /usr/bin/ksh93  for install-sfw* and add a
    > $ set -o errexit # at the beginning and replace
    > ". ${SRC}/tools/install.subr" with
    > "source ${SRC}/tools/install.subr" (the idea is to catch
    > failures in the script and abort it at that point,
    > right now the script will just continue)

    Should it be delivering the INSTALL file ?

END
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to