Jennifer Pioch wrote: > On 6/8/09, George Vasick <George.Vasick at sun.com> wrote: >> Hi Paul, >> >> See comments inline below. >> >> Paul Cunningham wrote: >> >>> George, >>> >>> This looks okay to me, but you could do the following ... >>> >>> Paul >>> >>> George Vasick wrote: >>> >>>> I am looking for reviewers for the upgrade of automake to 1.10.2: >>>> >>>> http://cr.opensolaris.org/~gvasick/automake/ >>>> >>> 1. usr/src/cmd/automake/automake-1.10/install-sfw >>> >>> Pass the VER= info in from the Makefile.sfw (so you >>> don't have to keep changing it for every src pkg version >>> update). >>> >> Done. >> >> >>> Apply the following ... >>> Roland Mainz wrote: >>> > use /usr/bin/ksh93 for install-sfw* and add a >>> > $ set -o errexit # at the beginning and replace >>> > ". ${SRC}/tools/install.subr" with >>> > "source ${SRC}/tools/install.subr" (the idea is to catch >>> > failures in the script and abort it at that point, >>> > right now the script will just continue) >>> >> Done. >> >> On a side note, I have a question regarding the difference between the "." >> command and the "source" source command. Source seems to be an alias for >> ".": >> >> (killebrew:bash) gvasick: ksh93 >> (killebrew:bash) gvasick: ps >> PID TTY TIME CMD >> 452499 pts/7 0:00 bash >> 452522 pts/7 0:00 ksh93 >> 452523 pts/7 0:00 ps >> (killebrew:bash) gvasick: type source >> source is an alias for 'command .' >> >> What am I missing? > > Try asking in shell-discuss at opensolaris.org. AFAIK source is an alias > for 'command .' which returns an error message when the parsing fails > instead if silently killing the shell with no error at all.
I ran a few tests and looked at truss output. The "." and source commands behaved identically. Both caught the error in the presence of "set -o errexit" and both continued without it. The truss outputs were almost, but not quite identical. Thanks, George > >>> Should it be delivering the INSTALL file ? >>> >> Good catch. I don't think so. I also removed the COPYING file. Updated >> webrev available: >> >> http://cr.opensolaris.org/~gvasick/automake/ >> >> >> Thanks, >> George >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> > >
