Jim, I've posted a new webrev with your comments incorporated. Except for removal of 64 bit binaries. Why do we not deliver these? We have compiled them.
-Rich Webrev: http://cr.opensolaris.org/~richrein/yaz/ Jim Walker wrote: > Rich Reinhard wrote: >> Hi all, >> >> I am porting the YAZ which is a programmers? toolkit supporting the >> development of Z39.50/SRW/SRU clients and servers. Would you please >> help review, any feedback would be much appreciated. >> >> Webrev: http://cr.opensolaris.org/~richrein/yaz/ >> > > Here are some comments: > > usr/src/lib/libyaz/METADATA > - Why aren't you porting version 3.0.46 now? > it's a micro change using the same license > so no new OSR is needed. Done, they changed rev on the day I sent out the code review request. > > Check all your files. The CDDL header and copyright blocks should > exactly match this: > http://cr.opensolaris.org/~richrein/yaz/usr/src/pkgdefs/Makefile.html Done > > Change the file names to the current standards: > > install-libyaz -> install-sfw > install-libyaz -> install-sfw-64 > > install-sfw and install-sfw-64 should look more like this: > http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/install-sfw.html > Add or replace these lines: > > 1 #! /usr/bin/ksh93 > > 29 set -o errexit > > 45 exit 0 > > Also, can install-sfw-64 only install the 64-bit files? > (ie. just the delta) The bins, include files, and man > pages don't need to be done twice. Done, install-sfw-64 is now only installing the delta > > usr/src/pkgdefs/SUNWlibyaz/copyright > - Remove the Bison,Autoconf... GPL special exception > license and just use the straight LICENSE file text > The Index Data group has been careful so that > only the Revised BSD license applies to this package > per your OSR. Done, Only the revised bsd license exists. > > usr/src/pkgdefs/SUNWlibyaz/depend > > You need to add the core packages above > the packages that you require: > > 45 P SUNWcar Core Architecture, (Root) > 46 P SUNWcakr Core Solaris Kernel Architecture (Root) > 47 P SUNWkvm Core Architecture, (Kvm) > 48 P SUNWcsr Core Solaris, (Root) > 49 P SUNWckr Core Solaris Kernel (Root) > 50 P SUNWcnetr Core Solaris Network Infrastructure (Root) > 51 P SUNWcsu Core Solaris, (Usr) > 52 P SUNWcsd Core Solaris Devices > 53 P SUNWcsl Core Solaris Libraries > 54 P SUNWcslr Core Solaris Libraries (Root) Done > > usr/src/pkgdefs/SUNWlibyaz/pkginfo.tmpl > - use these values, the version is needed in the DESC field: > 34 NAME="yaz" > 42 DESC="Z39.50/SRW/SRU client/server development toolkit (3.0.46)" Done > > usr/src/pkgdefs/SUNWlibyaz/prototype_com > - put the file list in alphabetic order and don't > clump the directories together, just keep files and > directories alphabetic > - do not deliver static libraries *.a *.la > > usr/src/pkgdefs/SUNWlibyaz/prototype_i386 > - do not deliver 64-bit commands > - do not deliver static libraries *.a *.la > > usr/src/pkgdefs/SUNWlibyaz/prototype_sparc > - do not deliver 64-bit commands > - do not deliver static libraries *.a *.la I have removed the *.a and *.la libraries and will need to update again if I really have to remove the 64 bit binaries. > > Why do you need separate 64-bit pkgconfig files? > usr/lib/*/pkgconfig/yaz.pc Done, This file is only installed once. > > Cheers, > Jim
