Jim, First thanks for reviewing. Jim, I have incorporated all you comments into the code along with Paul's. I have posted a new webrev and my comments are inline.
-Rich Jim Walker wrote: > Rich Reinhard wrote: >> Jim, >> >> I've posted a new webrev with your comments incorporated. Except for >> removal of 64 bit binaries. Why do we not deliver these? We have >> compiled them. >> >> -Rich >> >> Webrev: http://cr.opensolaris.org/~richrein/yaz/ >> > > Thanks. Just a few more nits: > > usr/src/lib/libyaz/Makefile.sfw > usr/src/lib/libyaz/install-sfw-* > > Use the technique shown here to pass the PKGDIR to > the install-sfw* scripts. I don't want VER* hard > coded in multiple places. > > http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/Makefile.sfw.html > http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/install-sfw.html > 41 install: all > 42 PKGDIR=$(VER) $(SHELL) ./install-sfw Done > > > usr/src/lib/libyaz/install-sfw > 106 # Include header files > 107 for i in \ > - why not change to: > for i in *.h > > - take a look at all your ksh93 for loops you shouldn't need to > use ls in your range expression, for example: > This: for i in `ls *.1` > should be: for i in *.1 > - and you can collapse some of the loops down, for example, > the doc and the man page loops can be simply: > for i in *.html *.png > for i in *.1 *.7 *.8 > Done, except for: # Include assignment files for i in \ ill.tcl \ ill9702.asn \ item-req.asn \ oclc-ill-req-ext.asn do _install N ${i} ${ILLDIR}/${i} 444 done for i in \ charneg-3.asn \ datetime.asn \ esadmin.asn \ esupdate.asn \ mterm2.asn \ oclcui.asn \ univres.asn \ z3950v3.asn \ z.tcl do _install N ${i} ${Z3950DIR}/${i} 444 done which reside in the same directory but are delivered into differing locations. > 64-bit command binaries are only delivered if they are needed. > It's very rare that they are needed. The ARC reviewers will > ask that they be removed if they are are not needed. This > is mentioned here under /usr/bin/sparcv9 etc... > http://www.opensolaris.org/os/community/arc/policies/install-locations/ > > Test to make sure they are not needed, then remove > them from: > > usr/src/lib/libyaz/install-sfw-64 > usr/src/pkgdefs/SUNWlibyaz/prototype_i386 > usr/src/pkgdefs/SUNWlibyaz/prototype_sparc > Done > Let me know when you have your arc materials ready and > send your man page text files and proposal draft to me > and I will sponsor you. > > Good job! > > Cheers, > Jim
