Rich, Looks good to me, see below for a few minor comments ...
Rich Reinhard wrote: > First thanks for reviewing. That's okay :-) Paul > I have incorporated all you comments > into the code along with Jim's. I have posted a new webrev and my > comments are inline. >> Rich Reinhard wrote: >>> I've posted a new webrev with your comments incorporated. Except for >>> removal of 64 bit binaries. Why do we not deliver these? We have >>> compiled them. >>> Webrev: http://cr.opensolaris.org/~richrein/yaz/ >> >>>> Rich Reinhard wrote: >>>>> I am porting the YAZ which is a programmers? toolkit supporting the >>>>> development of Z39.50/SRW/SRU clients and servers. Would you please >>>>> help review, any feedback would be much appreciated. >>>>> >>>>> Webrev: http://cr.opensolaris.org/~richrein/yaz/ >> 3. usr/src/lib/libyaz/Makefile.sfw you could align line 33-35 better with the lines below (eg. align the '=') > If there is a different way of doing this please let me know. I think you changed it as I was expecting you too :-) >> Lines ... >> 100 $(CHMOD) 755 $(VER)/configure >> 106 $(CHMOD) 755 $(VER64)/configure >> do you need to do these, or are they for "just-in-case" ? >> If they are for "just-in-case" you should probably remove >> them. > Removed Did you also remove the 'touch configure', I think you probably need that? >> 6. usr/src/pkgdefs/SUNWlibyaz/copyright >> Shouldn't this refer to it being "Revised BSD License" >> (from http://www.indexdata.dk/licensing/bsd/) somewhere >> in it. > Added line to copyright file indicating location of electronic copy of > license. Though I'm okay with what you have changed, what I really meant was: shouldn't the the words "Revised BSD License" also be included in the file somewhere?, eg. ... maybe change line 10/11 ... 10 Index Data 11 -------------------------------------------------------------- to .. 10 Revised BSD License 11 -------------------------------------------------------------- (but I don't really know about this licencing stuff) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
