Hi,
> I was wondering if someone could review my perl 5.10 integration. webrev
> at http://cr.opensolaris.org/~error404/6841312/
First of all, it surprises me a bit that usr/src/cmd/perl/contrib is not
ported. I can not see note about it in the arc case. So perl 5.10 won't
support Sun::Solaris modules? So making /usr/perl5/5.10.0/bin/perl the
default /usr/bin/perl is going to break customers scripts?
old/usr/src/cmd/Makefile:
usr/src/pkgdefs/Makefile:
- not clean diff, bringover & merge would be nice touch
usr/src/cmd/perl510/Makefile.sfw
- line 40 @find . -name core -exec rm -f {} \;
why? Isn't it hiding some problem?
usr/src/cmd/perl510/config.sh.i386
- Differences from perl 5.8 configuration
- use64bitint='undef' (is defined for 5.8)
- usefaststdio='undef' (is defined for 5.8)
- cppflags='-I/usr/gnu/include' (is empty for 5.8)
- libperl='libperl.a' (is 'lipberl.so in 5.8)
- various lib paths include '/opt/SUNWspro/...' which should not be needed I
think
- directories are weird
man1dir='//man/man1' (is /usr/perl5/5.8.4/man/man1 in 5.8; etc.)
scriptdir seems to be affected too
- usevendorprefix='undef' (is usevendorprefix='define')
- there are other differences, but these are critical IMO
config.sh.sparc will be similar I guess
- I recommend compare the config.sh to what ON gate is using
(usr/src/cmd/perl/5.8.4/$ARCH/config.sh)
I'm not regular reviewer, so I might be wrong somewhere...
Yay for the match operator ~~ !
Yay for named captures in regex !
--
Vlad
