> New webrev here: http://cr.opensolaris.org/~error404/6841312_u3/
Only nits, really.
usr/src/cmd/perl510/Makefile.sfw:
77 clean:
78 $(RM) -rf $(VER)
RM is defined as 'rm -f' so $(RM) -r is enough
usr/src/cmd/perl510/config.sh.i386:
87 ccflags='-I/usr/gnu/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_TS_ERRNO -DPERL_USE_SAFE_PUTENV -DPERL_USE_SAFE_PUTENV'
I wounder if -I/usr/gnu/include is needed and why? And
-DPERL_USE_SAFE_PUTENV is used twice.
>>>>> First of all, it surprises me a bit that usr/src/cmd/perl/contrib is
>>>>> not ported. I can not see note about it in the arc case. So perl
>>>>> 5.10 won't support Sun::Solaris modules? So making
>>>>> /usr/perl5/5.10.0/bin/perl the default /usr/bin/perl is going to
>>>>> break customers scripts?
>>>>>
>>> I talked to Alan about this and you're probably correct that it
>>> should be delivered together, so I'll get that done right away.
>>>
>>
>> Ah, I'm sorry to be messenger of band news then. Pity I haven't seen
>> the ARC case to speak up earlier. I hope that we won't find any
>> dependency between those modules and ONNV gate ...
>>
>
> I've looked it over and talked to some people and because of some cross
> dependencies and putback logs (the modules occasionally change when
> other stuff in ON changes ) I think it makes the most sense to keep the
> contrib/ modules in ON for the time being, so I guess a phase 1 of this
> project is delivering perl, phase 2 ( in a build or 3 ) being to update
> the stuff in O/N to deliver the 5.10 modules ( which I presume needs an
> ARC case ). So ultimately the modules are coming, just not now, and not
> through SFW :)
Right, that sounds sane. Unless we move /usr/bin/perl to 5.10, all is
good.
No more comments, thanks for your patience.
--
Vlad
