See comments below ... Paul
John Sonnenschein wrote: > > I was wondering if someone could review my perl 5.10 integration. webrev > at http://cr.opensolaris.org/~error404/6841312/ === Start of Comments === 1. METADATA Add a METADATA file as defined in "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 2. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile Resync these with the gate/clone so it does not look as though you are trying to change other stuff. 3. Top of files (most files) Change so that they conform to those in ... "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 4. usr/src/cmd/perl510/Makefile.sfw Line ... 28 VER=perl-5.10.0 extract the info from the METADATA added in (1); there are lots of examples of how to do that in the gate/clone. Add ... TARBALL=$(VER).tar.gz and then replace "$(VER).tar.gz" with "$(TARBALL) throughout Changes as follows ... Roland Mainz wrote: > Use "env - ..." and not "env ..." in the Makefiles to > make sure "configure"&&"make" only see the env variables > they should really get(and not pick-up any random env variable) > Use either $(SHELL) for "configure" calls (so > we know which one is used and "configure" doesn't pick one >itself) Line ... 40 @find . -name core -exec rm -f {} \; is this really required? if not delete it Line .. 69 gzip -dc $(VER).tar.gz | tar xopf - change 'tar' to '$(TAR) Do you need the bracket lines 70 and 73? 5. usr/src/pkgdefs/SUNWperl510/copyright Add source owner copyright lines, extracted from the files in the unpacked src tarball. 6. usr/src/pkgdefs/SUNWperl510/depend Move the copyright lines to after the 'CDDL HEADER END' header. This looks like the default 'depend' file, have you checked there are no other dependencies? If there are add them, if not then delete this file and instead add "DATAFILES= depend" into SUNWperl510/Makefile (so it uses the default one). 7. usr/src/pkgdefs/SUNWperl510/pkginfo.tmpl Add the version to the end of the DESC= line so it is the same as other recent integrations, eg ... DESC="................... (5.10.0)" 8. usr/src/pkgdefs/SUNWperl510/prototype_com Do not install files (f) into /usr with the write permission bit set, ie. change 755 to 555, and 644 to 444 You will probably have to run 'protofix' in Makefile.sfw/install so that it corrects the permissions in the ws proto area (see examples in the gate, eg. cups). === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
