Marcel, See below for comments ...
Paul Marcel Telka wrote: > > Please review the webrev covering upgrade of mutt to version 1.5.19: > http://cr.opensolaris.org/~aragorn/6787900/ > > mutt is popular text based e-mail client. The current integrated version > (1.5.17) is more than 1 year old. The proposed change is integrating mutt > version 1.5.19, released upstream on January 5, 2009. > > Please help with this review to have the latest-greatest stuff in the > distribution. === Start of Comments === 1. METADATA If you have a METADATA file it probably needs updating, if there isn't one then add one. See ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. usr/src/cmd/mutt/Makefile.sfw You can extract the ... 33 VER = 1.5.19 34 PROJECT = mutt info from the METADATA file, see recent sfw integrations for examples. Change so that the 'configure --prefix==...' value is got from the predefined CFGPREFIX in Makefile.master .. http://src.opensolaris.org/source/xref/sfw/usr/src/Makefile.master Or you could even use the preferred CONFIGURE_OPTIONS method, eg. .... CONFIGURE_OPTIONS += --libdir=$(CFGPREFIX)/share/mutt CONFIGURE_OPTIONS += --sysconfdir=$(CFGETC)/mutt etc. ./configure $(CONFIGURE_OPTIONS) Add 'env - ' before './configure ...' & Add 'env - ' in ... 82 (cd $(PROD); env - $(CCSMAKE) MAKE=$(CCSMAKE)) So ... Roland Mainz wrote: > use "env - ..." and not "env ..." in the Makefiles > to make sure "configure"&&"make" only see the env > variables they should really get (and not pick-up any > random env variable) > Use either $(SHELL) or /usr/bin/bash for "configure" > calls (so we know which one is used and "configure" > doesn't pick one itself) 3. usr/src/pkgdefs/SUNWmutt/pkginfo.tmpl & usr/src/pkgdefs/SUNWmuttr/pkginfo.tmpl Remove the version on the NAME= line === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
