On Fri, Feb 13, 2009 at 02:24:12PM -0700, Jim Walker wrote: > Marcel Telka wrote: >>>>> I updated the webrev with (hopefully) all of your valuable suggestions: >>>>> http://cr.opensolaris.org/~aragorn/6787900/ >>>> I just realized I forgot to update copyright files. >>>> The webrev is updated. >>> You can reduce things down to this. You don't need to repeat >>> license headers in the copyright file since you have the >>> full license. Short is sweet :) >> >> I agree, but the current approach is simpler. Reasons: >> >> 1. I leverage the previous mutt 1.5.17 integration. :-) >> 2. The current license files are constructed in this way: >> >> cat usr/src/cmd/mutt/mutt-1.5.19/COPYRIGHT usr/src/cmd/mutt/mutt-1.5.19/GPL > > You can do what you like in this case since you have the
Ok. Then I'll leave it as is. At least for now. > three parts. I'm just letting you know that the copyright Thank you. Your comments are really appreciated. > file can be cleaned up, and saying something was done > before doesn't necessarily make it right. That's big truth! Could I consider your involvement as a "go" regarding this code review? :-) Have a nice day. -- Marcel Telka Solaris RPE
