Marcel Telka wrote: >>>> I updated the webrev with (hopefully) all of your valuable suggestions: >>>> http://cr.opensolaris.org/~aragorn/6787900/ >>> I just realized I forgot to update copyright files. >>> The webrev is updated. >> You can reduce things down to this. You don't need to repeat >> license headers in the copyright file since you have the >> full license. Short is sweet :) > > I agree, but the current approach is simpler. Reasons: > > 1. I leverage the previous mutt 1.5.17 integration. :-) > 2. The current license files are constructed in this way: > > cat usr/src/cmd/mutt/mutt-1.5.19/COPYRIGHT usr/src/cmd/mutt/mutt-1.5.19/GPL
You can do what you like in this case since you have the three parts. I'm just letting you know that the copyright file can be cleaned up, and saying something was done before doesn't necessarily make it right. Cheers, Jim
