John, This mainly looks good to me, see below for minor comments below ...
Paul John Cui wrote: > Can I please get a review for AWstats? > > AWStats is a free powerful and featureful tool that generates advanced > web, streaming, ftp or mail server statistics, graphically. This log > analyzer works as a CGI or from command line and shows you all possible > information your log contains, in few graphical web pages. It uses a > partial information file to be able to process large log files, often > and quickly. It can analyze log files from all major server tools like > Apache log files (NCSA combined/XLF/ELF log format or common/CLF log > format), WebStar, IIS (W3C log format) and a lot of other web, proxy, > wap, streaming servers, mail servers and some ftp servers. > > Webrev: http://cr.opensolaris.org/~johncui/awstats/ === Start of Comments === 1. usr/src/cmd/awstats/METADATA Make the NAME: field more descriptive 2. CDDL HEADERs Make the CDDL HEADER blocks in all files consistent with these ... http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototyp eg. double space chars, etc. 3. usr/src/pkgdefs/SUNWawstats/depend Delete the null DATAFILES= line === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
