Looks good to me :-)

Paul

John Cui wrote:
> Oops,  :-[
> 
> Please access
> http://cr.opensolaris.org/~johncui/awstats/incr_webrev.2/
> http://cr.opensolaris.org/~johncui/awstats/webrev.2/
> 
> Thanks,
> 
> Paul Cunningham wrote on 02/12/09 16:30:
>> John,
>>
>> The CDDL HEADER in usr/src/cmd/awstats/Makefile.sfw still looks 
>> slightly wrong to me (ie. double space char after #) Change ...
>>    #  ....
>> to
>>    # ....
>>
>> otherwise it all looks good to me
>>
>> paul
>>
>>
>> John Cui wrote:
>>
>>> Thanks for your comments, I updated them.
>>
>>> Updated full set: http://cr.opensolaris.org/~johncui/awstats/webrev.1/
>>
>>>>
>>>> 2. CDDL HEADERs
>>>>    Make the CDDL HEADER blocks in all files consistent with
>>>>    these ...
>>>> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototyp
>>>>    eg. double space chars, etc.
>>


-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to