John Cui wrote: > Oops, :-[ > > Please access > http://cr.opensolaris.org/~johncui/awstats/incr_webrev.2/ > http://cr.opensolaris.org/~johncui/awstats/webrev.2/ >
Good job. Just a few comments... usr/src/pkgdefs/SUNWawstats/prototype_com I would locate the files under: usr/lib/awstats/docs usr/lib/awstats/tools usr/lib/awstats/wwwroot the /usr/* namespace is tightly controlled but /usr/lib/* is more open. You shouldn't mix ../wwwroot/* and ../tools/* and ../wwwroot/* like this. Keep all the files in the same directory together and order things alphabetically. 618 f none usr/awstats/wwwroot/icon/other/vu.png 0444 root bin 619 f none usr/awstats/wwwroot/icon/other/vv.png 0444 root bin 620 d none usr/awstats/wwwroot/js 0755 root bin 621 f none usr/awstats/wwwroot/js/awstats_misc_tracker.js 0444 root bin 622 d none usr/awstats/tools 0755 root bin 623 f none usr/awstats/tools/awstats_buildstaticpages.pl 0555 root bin 624 f none usr/awstats/tools/awstats_configure.pl 0555 root bin 625 f none usr/awstats/tools/awstats_exportlib.pl 0555 root bin 626 f none usr/awstats/tools/awstats_updateall.pl 0555 root bin 627 f none usr/awstats/tools/httpd_conf 0444 root bin 628 f none usr/awstats/tools/logresolvemerge.pl 0555 root bin 629 f none usr/awstats/tools/maillogconvert.pl 0555 root bin 630 f none usr/awstats/tools/urlaliasbuilder.pl 0555 root bin 631 d none usr/awstats/tools/webmin 0755 root bin 632 f none usr/awstats/tools/webmin/awstats-1.7.wbm 0555 root bin 633 d none usr/awstats/tools/xslt 0755 root bin 634 f none usr/awstats/tools/xslt/README.txt 0444 root bin 635 f none usr/awstats/tools/xslt/awstats.datademo1.xml 0555 root bin 636 f none usr/awstats/tools/xslt/awstats.datademo1.xslt 0555 root bin 637 f none usr/awstats/tools/xslt/awstats.xsd 0555 root bin 638 d none usr/awstats/wwwroot/cgi-bin 0755 root bin 639 f none usr/awstats/wwwroot/cgi-bin/awredir.pl 0555 root bin 640 f none usr/awstats/wwwroot/cgi-bin/awstats.model.conf 0644 root bin Cheers, Jim Jim Walker, http://blogs.sun.com/jwalker Sun Microsystems, Broomfield, Colorado
