I missed a bit ...
Paul Cunningham wrote:
> Hi Danek,
>
> This looks mainly okay to me, but you might want to consider the
> comments below ...
>
> Paul
>
> Danek Duvall wrote:
>> This is a "simple" upgrade to ggrep:
>>
>> http://cr.opensolaris.org/~dduvall/ggrep-2.5.4/
>>
>
> 1. usr/src/cmd/ggrep/Makefile.sfw
> Roland Mainz wrote:
> > Use "env - ..." and not "env ..." in the Makefiles to
> > make sure "configure"&&"make" only see the env variables
> > they should really get (and not pick-up any random env
> > variable)
> > Use either $(SHELL) or /usr/bin/bash for "configure"
> > calls (so we know which one is used and "configure"
> > doesn't pick one itself)
>
> Does it really need the ...
> 41 @find . -name core -exec rm -f {} \;
> if not remove it.
>
> 2. usr/src/cmd/ggrep/install-sfw
> Roland Mainz wrote:
> > Use /usr/bin/ksh93 or /usr/bin/bash for install-sfw*
> > and add a $ set -o errexit # at the beginning and replace
> > ". ${SRC}/tools/install.subr" with
> > "source ${SRC}/tools/install.subr" (the idea is to catch
> > failures in the script and abort it at that point,
> > right now the script will just continue)
>
> Should this ...
> 60 _install N ${i} ${MAN1DIR}/g${i} 444
> be ...
> _install M ${i} ${MAN1DIR}/g${i} 444
> so the sunman-stability bits are added?
>
> 3. usr/src/pkgdefs/SUNWggrp/copyright
> You might need to add the disclaimer and pkg copyright
> statements, eg. as in ...
> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright";
>
4. METADATA
Shouldn't this have been updated (or show up in the webrev)
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
