On Mon, Feb 16, 2009 at 08:24:26AM +0000, Paul Cunningham wrote:
> 1. usr/src/cmd/ggrep/Makefile.sfw
>
> Does it really need the ...
> 41 @find . -name core -exec rm -f {} \;
> if not remove it.
Gone.
> 2. usr/src/cmd/ggrep/install-sfw
>
> Should this ...
> 60 _install N ${i} ${MAN1DIR}/g${i} 444
> be ...
> _install M ${i} ${MAN1DIR}/g${i} 444
> so the sunman-stability bits are added?
Actually, no. Those two files simply ".so grep.1", so running them through
the sed script ends up giving you a man page that has that information
twice. Take a look at gfgrep(1) now, and you'll see two ATTRIBUTES
sections (the first garbled) and two NOTES sections.
Good eye, though. :)
> 3. usr/src/pkgdefs/SUNWggrp/copyright
> You might need to add the disclaimer and pkg copyright
> statements, eg. as in ...
> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright";
Still waiting on legal for that. I jumped the gun a bit there, having
gotten back a note that said "accepted" and thought it said "approved".
> 4. METADATA
> Shouldn't this have been updated (or show up in the webrev)
Oops, thanks.
Webrev updated.
Thanks,
Danek
