Jeffrey, See below for my comments ...
Paul Jeffrey Huang wrote: > > Resend for the correct webrev link: > http://cr.opensolaris.org/~jeffreyh/epydoc > <http://cr.opensolaris.org/%7Ejeffreyh/epydoc/> > > Jeffrey Huang wrote: >> I am porting 'epydoc', an automatic api documentation generation for python >> to OpenSolaris, >> epydoc is written in Python. >> >> Can you please have a review on my code. The webrev is at: === Start of Comments ==== 1. usr/src/Targetdirs & usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile This looks as though it needs resyncing with the ws gate otherwise it looks as though you are trying to delete stiff 2. usr/src/cmd/epydoc/METADATA Cosmetic: align the fields better, eg. NAME: automatic api documentation generation for python PROGRAM: epydoc etc 3. usr/src/cmd/epydoc/Makefile.sfw Cosmetic: Remove the double space chars in the CDDL HEADER, eg .. # .... becomes .. # .... 4. usr/src/cmd/epydoc/sunman-stability I don't think this needs the CDDL HEADER stuff? 5. usr/src/pkgdefs/SUNWepydoc/copyright The epydoc/METADATA says "LICENSE: MIT License" so shouldn't that licence be included here. Add the copyright lines from the pkg src at the top, see .. "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 6. usr/src/pkgdefs/SUNWepydoc/prototype_com Remove the write permission bit from the files in /usr === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
