Hi, Paul, Webrev is updated with your comments: http://cr.opensolaris.org/~jeffreyh/epydoc/ <http://cr.opensolaris.org/%7Ejeffreyh/epydoc/>
Please see inline. Great Thanks Jeffrey Paul Cunningham ??: > Jeffrey, > > This looks good. See below for a couple of comments ... > > Paul > > Jeffrey Huang wrote: >> >> Thanks very much of your review, all the comments are very well >> except the license issues >> that I am not quite clear, please see inline > >> http://cr.opensolaris.org/~jeffreyh/epydoc/ > >> >> Paul Cunningham wrote: > >>> >>> 2. usr/src/cmd/epydoc/METADATA >>> Cosmetic: align the fields better, eg. >>> NAME: automatic api documentation generation for python >>> PROGRAM: epydoc >>> etc > > you could align the fields better (but it maybe webrev messing it up), > ie. > 4 PACKAGE: SUNWepydoc > 5 LICENSE: MIT License > -> 6 URL: http://sourceforge.net/projects/epydoc > -> 7 SRC: http://downloads.sourceforge.net/epydoc/epydoc-3.0.1.tar.gz > 8 SUPPORT: Community > 9 BUGTRAQ: solaris/utility/eypdoc > ->10 OSR: 10594 > 11 OWNER: Jeffrey Huang<jeffrey.huang at sun.com> Yes, aligned. Probably because I used gedit that caused the issue, now I am using vi. > >>> 5. usr/src/pkgdefs/SUNWepydoc/copyright >>> The epydoc/METADATA says "LICENSE: MIT License" so >>> shouldn't that licence be included here. >> I checked the source and >> http://www.opensource.org/licenses/mit-license.php, >> the MIT license are these words, any other license should I put? > > okay - I was just checking (I didn't know what the MIT licence looked > like). > >>> Add the copyright lines from the pkg src at the top, see .. >>> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; >>> >>> >> meld is GPL v2 license, should I add that? Or add the first 10 lines >> above my license? > > I think you need to add the pkg owner copyright lines from the pkg's > source files, eg. for meld they were (extract) ... > 11 Copyright (C) 2002-2006 Stephen Kennedy <stevek (a] gnome.org> > 12 Copyright (C) 2003-2007 Free Software Foundation, Inc. > etc. > so I think you need to add the equivalent for eypdoc (at the top) Accepted, added author's copyright at the top. > > -- Great Thanks & Best Regards --- Jeffrey Huang SWAN: x51683, Ext: 0086-10-62673683 Solaris QE Group Email: jeffrey.huang at sun.com China Engineering & Research Institute, Sun Microsystems 7/F Chuang Xin Plaza, Tsinghua Science Park, Beijing China
