On Wed, Feb 25, 2009 at 02:51:53PM +0100, Petr Sumbera wrote: > Hi, > > I have prepared webrev for Wireshark integration to Solaris Nevada (PSARC > PSARC/2007/334). Can somene do code review for me? > > http://cr.opensolaris.org/~xsumbe00/6567201-wireshark/
usr/src/cmd/wireshark/Makefile.sfw ---------------------------------- Do you really need to pass whole TARGET_ENV to make commands? For example (at least) INSTALL shouldn't be required. According to http://www.gnu.org/software/autoconf/manual/html_node/Defining-Variables.html#Defining-Variables the better way how to run the configure script should be ./configure $(TARGET_ENV) instead of $(TARGET_ENV) ./configure -- Marcel Telka Solaris RPE
