Hi,

> I guess that mean I need a code review. Here is the upload:
> http://cr.opensolaris.org/~brandorr/firstreview/webrev/

I just wonder why all the patches are included if we are not patching
the sources ?

============================= Makefile.sfw =============================
  28 VER=vim71
  29 # we don't include extra patches from vim community
  30 # (those are not present in this directory)
  31 PATCHES=../vim-patches/7.1.*

...

  67 $(VER)/configure: $(VER).tar.bz2
  68         /usr/sfw/bin/gtar xfvj $(VER).tar.bz2
  69         #( \
  70             cd $(VER) && \
  71             for patchFile in $(PATCHES); \
  72             do \
  73                 gpatch -p0 < $$patchFile ; \
  74             done; \
  75             gpatch -p1 < ../solaris.patch; \
  76 #       )
  77 #       touch $(VER)/configure
========================================================================

-- 
        Vlad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 193 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080916/03867774/attachment.bin>

Reply via email to