Sorry about that, I had commented out the patches while debugging last night. Thanks for catching it, I will have another webrev up shortly.
-Brian On Tue, Sep 16, 2008 at 5:19 AM, Vladimir Marek <Vladimir.Marek at sun.com> wrote: > Hi, > >> I guess that mean I need a code review. Here is the upload: >> http://cr.opensolaris.org/~brandorr/firstreview/webrev/ > > I just wonder why all the patches are included if we are not patching > the sources ? > > ============================= Makefile.sfw ============================= > 28 VER=vim71 > 29 # we don't include extra patches from vim community > 30 # (those are not present in this directory) > 31 PATCHES=../vim-patches/7.1.* > > ... > > 67 $(VER)/configure: $(VER).tar.bz2 > 68 /usr/sfw/bin/gtar xfvj $(VER).tar.bz2 > 69 #( \ > 70 cd $(VER) && \ > 71 for patchFile in $(PATCHES); \ > 72 do \ > 73 gpatch -p0 < $$patchFile ; \ > 74 done; \ > 75 gpatch -p1 < ../solaris.patch; \ > 76 # ) > 77 # touch $(VER)/configure > ======================================================================== > > -- > Vlad > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > > -- - Brian Gupta http://opensolaris.org/os/project/nycosug/ http://www.genunix.org/wiki/index.php/OpenSolaris_New_User_FAQ
