Sagun, Took a quick look, below are a few minor comments ..
Paul sagun shakya wrote: > Folks, > > The PSARC fasttrack (2008/288) for integrating libpcap into the SFW > consolidation is on going. I would like to request a code review for > libpcap's integration into the sfw consolidation. > > The webrev is located at: > > http://cr.opensolaris.org/~sagun/libpcap-sfw/ === Start of Comments === 1. METADATA Your don't seem to have a METADATA file for your new package. 2. usr/src/cmd/nmap/Makefile.sfw Is there a reason why you have removed the explicit '--prefix=' from 'configure'? 3. usr/src/lib/libpcap/Makefile.sfw You don't seem to have explicitly defined '--prefix=' on 'configure' (I think it's normal SFW practice to do so). Also you could do this using the predefined stuff in Makefile.master, see example at http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html Why are you using '-I/usr/local/include' ? You have copied various .c and .h files into the src, could these have been patches to the original (in the tarball) instead? 4. Everything else looks good to me === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
