Thank you Paul, I've address your comments and generated a new webrev. Please see my responses to your comments inline.
Webrev for Paul's comments: http://cr.opensolaris.org/~sagun/libpcap-postreview/ Webrev against sfw gate: http://cr.opensolaris.org/~sagun/libpcap-sfw/ There is one warning I see and was wandering if any compiler expert could answer this: While compiling libpcap in 64bit sparc I was getting this error: ld: fatal: relocation error: R_SPARC_M44: file pcap-libdlpi.o: symbol .rodata1 (section): relocations based on the ABS44 coding model can not be used in building a shared object I found that adding the -xcode=pic32 to the CFLAGS fixed it. But when compiling libpcap 64bit in i386 I get this warning. although the shared library is built? cc: Warning: illegal option -xcode=pic32 Paul Cunningham wrote: > === Start of Comments === > > 1. METADATA > Your don't seem to have a METADATA file for your new package. > I hadn't seen this in existing libraries in SFW but I had noticed the METADATA file in the current code reviews. However, I missed including the file. I've added it. I wasn't sure what exactly needed to go into the METADATA file so based it on what was in libdvdnav. > 2. usr/src/cmd/nmap/Makefile.sfw > Is there a reason why you have removed the explicit > '--prefix=' from 'configure'? > Restored bask as it was before. > 3. usr/src/lib/libpcap/Makefile.sfw > You don't seem to have explicitly defined '--prefix=' on > 'configure' (I think it's normal SFW practice to do so). > Also you could do this using the predefined stuff in > Makefile.master, see example at > http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html > Fixed to used predefined stuff. > Why are you using '-I/usr/local/include' ? > This is an error. I've fixed it. > You have copied various .c and .h files into the src, > could these have been patches to the original (in the > tarball) instead? > Do you mean a patch to the libpcap0.9.8 tarball upstream? If so, no. Elaborating a bit more - all the changes patch/new files have been integrated upstream in the main libpcap gate and the libpcap1.0 tree. Since we do not have a confirmed date on when libpcap1.0 is coming out I'm patching libpcap0.9.8. Does that answer your question? Thanks, Sagun -- Sagun Shakya 781.442.7344/ X27344 sagun.shakya at sun.com
