sagun shakya wrote: > > During the last code review, changes to $SRC/pkgdefs/SUNWnmap/depend was > missing. Since nmap after libpcap is integrated will depend upon > libpcap.so so this change is needed. > > I would appreciate it if you could review the changes made to > usr/src/pkgdefs/SUNWnmap/depend. The remaining changes in the webrev are > the same as in the last round of code review. > > The webrev is located at: > > http://cr.opensolaris.org/~sagun/libpcap-postreview/
'usr/src/pkgdefs/SUNWnmap/depend' looks okay to me; but you may want to move the 'copyright' lines to after the 'CDDL HEADER END' header. Also note, your 'usr/src/pkgdefs/Makefile' currently looks as though you are trying to delete stuff (probably need resync to gate). Paul > > sagun shakya wrote: > >>Folks, >> >>The PSARC fasttrack (2008/288) for integrating libpcap into the SFW >>consolidation is on going. I would like to request a code review for >>libpcap's integration into the sfw consolidation. >> >>The webrev is located at: >> >>http://cr.opensolaris.org/~sagun/libpcap-sfw/ >> -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
