On Fri, Feb 29, 2008 at 03:54:39PM -0800, Danek Duvall wrote: > On Fri, Feb 29, 2008 at 04:18:42PM -0600, Nicolas Williams wrote: > > > http://cr.opensolaris.org/~nico//webrev-sqlite3-sfw-the-3rd/ > > > - The relevant SQLite3 executables and shared objects are now built > > differently. Just patch the SQLite3 Makefile.in to build things the > > Solaris way. This turns out to be a trivial patch by taking > > advantage of the SQLite3 "amalgamation." > > Is this actually simpler than Norm's supposed one-or-two-line fix? Or did > that not actually work?
Norm's fix (I didn't notice a fix) doesn't cause the executable nor the Tcl bindings to dynamically link with libsqlite3.so -- by default SQLite3 builds the library into the command and into the bindings. > > - Added an install_h target to $SRC/lib/sqlite3/Makefile.sfw > > ($SRC/lib/Makefile makes install_h in $(SUBDIRS)). > > Isn't install_h run before all, or at least part of setup? This target > seems a bit heavyweight for that at the moment. Er, what do you recommend? > > - Added readline support (including dependency info in > > $SRC/lib/Makefile). > > Like I mentioned in my checklist review, readline isn't shipped. Someone > else probably remembers why we build it anyway. It's statically linked in, since that's all that's installed into the proto area. > Makefile.sfw: > > - line 172: Why are you copying the original aside? It helped me while developing the patch. I can remove this before integration. > Makefile.in.diff: > > - line 50: Why is curses needed? Readline needs it. > - line 56: Why is -L/usr/lib needed? Er, it isn't. Thanks!
