On Fri, Feb 29, 2008 at 04:18:42PM -0600, Nicolas Williams wrote: > http://cr.opensolaris.org/~nico//webrev-sqlite3-sfw-the-3rd/
> - The relevant SQLite3 executables and shared objects are now built > differently. Just patch the SQLite3 Makefile.in to build things the > Solaris way. This turns out to be a trivial patch by taking > advantage of the SQLite3 "amalgamation." Is this actually simpler than Norm's supposed one-or-two-line fix? Or did that not actually work? > - Added an install_h target to $SRC/lib/sqlite3/Makefile.sfw > ($SRC/lib/Makefile makes install_h in $(SUBDIRS)). Isn't install_h run before all, or at least part of setup? This target seems a bit heavyweight for that at the moment. > - Added readline support (including dependency info in > $SRC/lib/Makefile). Like I mentioned in my checklist review, readline isn't shipped. Someone else probably remembers why we build it anyway. Makefile.sfw: - line 172: Why are you copying the original aside? Makefile.in.diff: - line 50: Why is curses needed? - line 56: Why is -L/usr/lib needed? Danek
