http://cr.opensolaris.org/~nico//webrev-sqlite3-sfw-the-3rd/
This is much simpler than before. Changes: - No more $SRC/lib/sqlite3/install-sfw script. All the install targets are now handled via traditional makefile targets and macros. - The relevant SQLite3 executables and shared objects are now built differently. Just patch the SQLite3 Makefile.in to build things the Solaris way. This turns out to be a trivial patch by taking advantage of the SQLite3 "amalgamation." We use the existing support in the build system for building sqlite3.c, a single file version of all of the headers and sources that go into libsqlite3, then with three simple targets we build the three desired ELF files without libtool in the way. I wish I'd thought of this earlier -- it would have saved me and you (the reviewers) a lot of time. - I also got rid of $SRC/pkgdefs/SUNWsqlite3/prototype_com_nodocs. This was causing "$(SRC)/tools/protofix --perm --pkg SUNWsqlite3" to fail in $SRC/lib/sqlite3/Makefile.sfw's install target. - Added an install_h target to $SRC/lib/sqlite3/Makefile.sfw ($SRC/lib/Makefile makes install_h in $(SUBDIRS)). - Fixed perms for /usr/lib/tcl8.4/sqlite3/(amd64|sparcv9) (was 555, now is 755). - Added readline support (including dependency info in $SRC/lib/Makefile). Hopefully the code review will now go very smoothly, as the new bits are much simpler than before. I'll be filing the c-team checklist next. Thanks! Nico --
