Thank you Paul for reviewing the changes. Paul Cunningham wrote: > > > sagun shakya wrote: >> >> During the last code review, changes to $SRC/pkgdefs/SUNWnmap/depend >> was missing. Since nmap after libpcap is integrated will depend upon >> libpcap.so so this change is needed. >> >> I would appreciate it if you could review the changes made to >> usr/src/pkgdefs/SUNWnmap/depend. The remaining changes in the webrev >> are the same as in the last round of code review. >> >> The webrev is located at: >> >> http://cr.opensolaris.org/~sagun/libpcap-postreview/ > > 'usr/src/pkgdefs/SUNWnmap/depend' looks okay to me; but you may want > to move the 'copyright' lines to after the 'CDDL HEADER END' header. I've moved the 'copyright' lines as suggested. > > Also note, your 'usr/src/pkgdefs/Makefile' currently looks as though > you are trying to delete stuff (probably need resync to gate). > Yes, a resync to the gate had not been done. I've done that and generated a new webrev.
Thanks, Sagun
