Carol, See below for my comments from my quick skip through ..
Paul On Fri, 2008-06-20 at 01:19, Carol Fields wrote: > Requesting a code review of changes to integrate GNU sed into OpenSolaris. > webrev: http://cr.opensolaris.org/~fields/gsed/ === Start of Comments === 1. usr/src/cmd/gsed/Makefile.sfw You are hard coding '--prefix=', you might want to use the predefined value in CONFIGURE_OPTIONS, see http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html 2. Everything else looks okay to me :-) === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
