Roland Mainz wrote: > Carol Fields wrote: >> Requesting a code review of changes to integrate GNU sed into OpenSolaris. >> webrev: http://cr.opensolaris.org/~fields/gsed/ > > Most stuff looks Ok... > 1. ... it would be nice to use this in Makefile.sfwnv > -- snip -- > CFLAGS += $(XPG6MODE) $(XSTRCONST) > -- snip -- > ... and then pass CFLAGS to the "configure" and "make" calls.
Thank you for reviewing the code. Note that the code is compiled with gcc because it wouldn't compile using the Sun Studio compiler. XSTRCONST: gcc has no -xstrconst option. XPG6MODE: Did you suggest this change so that GNU sed complies with XPG6 as much as possible? If we want to change from: CC=$(GCC) \ to: CC="$(GCC) -std=c99" \ then it compiles with lots of warnings, whereas currently it compiles with no warnings. Comments? > > 2. Please use "env -" and not "env" and only pass those environment > variables which are needed for the "configure" and "make" passes (this > avoids that other environment variables can "bleed through" into > "configure" and mess it up somehow). Okay, I'll make this change. > > ---- > > Bye, > Roland >
