Roland Mainz wrote: > Carol Fields wrote: > > Roland Mainz wrote: > > > Carol Fields wrote: > > >> Requesting a code review of changes to integrate GNU sed into > > OpenSolaris. > > >> webrev: http://cr.opensolaris.org/~fields/gsed/ > > > > > > Most stuff looks Ok... > > > 1. ... it would be nice to use this in Makefile.sfwnv > > > -- snip -- > > > CFLAGS += $(XPG6MODE) $(XSTRCONST) > > > -- snip -- > > > ... and then pass CFLAGS to the "configure" and "make" calls. > > > > Thank you for reviewing the code. > > Note that the code is compiled with gcc because it wouldn't compile using > > the Sun Studio compiler. > > Erm... can you send me the error log via email, please ? Maybe I can > craft a small patch for this... [snip]
Grumpf... I found the reason... the xx@@@!-half-broken GNU UTF-8 "optimisation" ... ;-( Patch follows... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL <currently fluctuating> (;O/ \/ \O;)
