Colin, See below for my comments from my quick skip through ...
Paul > -----Original Message----- > From: sfwnv-discuss-bounces at opensolaris.org > [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Colin Ngam > Sent: 23 June 2008 14:45 > To: sfwnv-discuss at opensolaris.org; solaris-qe-pkgproj at Sun.COM > Cc: Colin Ngam > Subject: [sfwnv-discuss] Request for code review - logrotate utility > > Hi, > > This is a request for code review. Please see > http://cr.opensolaris.org/~cn162287/logrotate/webrev > > And provide any comments or changes I need to make. === Start of Comments === 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile This needs resyncing with gate otherwise it looks as though you are trying to delete stuff. 2. usr/src/pkgdefs/SUNWlogrotate/prototype_com Shouldn't the 'etc/...' stuff be in a separate root package? 3. usr/src/pkgdefs/SUNWlogrotate/depend I can't see this file link - permissions wrong? 4. usr/src/cmd/logrotate/METADATA I don't think its normal to have the sccs ident stuff in a METADATA file. I don't know if it matters though either. 5. usr/src/cmd/logrotate/Makefile.sfw Does this source package have a 'configure' file? if not you may want to add comment to say so and that the 'touch' is just there to aid make 6. usr/src/cmd/logrotate/install-sfw The 'INFODIR=' line is not used so delete it === End of Comments =====
