Cunningham, Paul - UK wrote: > Colin, > > See below for my comments from my quick skip through ... > > Paul > > >> -----Original Message----- >> From: sfwnv-discuss-bounces at opensolaris.org >> [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Colin Ngam >> Sent: 23 June 2008 14:45 >> To: sfwnv-discuss at opensolaris.org; solaris-qe-pkgproj at Sun.COM >> Cc: Colin Ngam >> Subject: [sfwnv-discuss] Request for code review - logrotate utility >> >> Hi, >> >> This is a request for code review. Please see >> http://cr.opensolaris.org/~cn162287/logrotate/webrev >> >> And provide any comments or changes I need to make. >> > > === Start of Comments === > > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > This needs resyncing with gate otherwise it looks as > though you are trying to delete stuff. > okay > 2. usr/src/pkgdefs/SUNWlogrotate/prototype_com > Shouldn't the 'etc/...' stuff be in a separate > root package? > Can someone help me out here? I am installing a sample configuration file into /etc/logrotate.conf .. what is a root package?
PKG="SUNWlogrotate" NAME="Logrotate - rotates and compresses log file" ARCH="ISA" VERSION="SFWVERS,REV=0.0.0" SUNW_PRODNAME="SunOS" SUNW_PRODVERS="RELEASE/VERSION" SUNW_PKGTYPE="usr" MAXINST="1000" CATEGORY="system" DESC="Logrotate - rotates and compresses log file (3.7.1)" VENDOR="Sun Microsystems, Inc." HOTLINE="Please contact your local service provider" EMAIL="" CLASSES="none" BASEDIR=/ SUNW_PKGVERS="1.0" SUNW_PKG_ALLZONES="false" SUNW_PKG_HOLLOW="false" SUNW_PKG_THISZONE="false" The prototype_com file looks like: d none usr 0755 root sys d none usr/sbin 0755 root bin f none usr/sbin/logrotate 0555 root bin d none usr/share 0755 root sys d none usr/share/man 0755 root bin d none usr/share/man/man1 0755 root bin f none usr/share/man/man1/logrotate.1 0444 root bin > 3. usr/src/pkgdefs/SUNWlogrotate/depend > I can't see this file link - permissions wrong? > Corrected > 4. usr/src/cmd/logrotate/METADATA > I don't think its normal to have the sccs ident > stuff in a METADATA file. I don't know if it > matters though either. > Tools complain .. so I added it to shut it up. > 5. usr/src/cmd/logrotate/Makefile.sfw > Does this source package have a 'configure' file? if not > you may want to add comment to say so and that the 'touch' > is just there to aid make > No configure file. > 6. usr/src/cmd/logrotate/install-sfw > The 'INFODIR=' line is not used so delete it > Okay. Thanks. colin > === End of Comments ===== > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
